Skip to content

Fix test_xfail_behavior with pytest 7.2.0+ #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

swt2c
Copy link
Contributor

@swt2c swt2c commented Dec 6, 2022

In pytest-dev/pytest@69fb79e, pytest output was changed to include the reason string on the same line as the short test summary, so the test needs to be updated correspondingly.

In pytest-dev/pytest@69fb79e,
pytest output was changed to include the reason string on the same line as
the short test summary, so the test needs to be updated correspondingly.
@frenzymadness
Copy link

Looks good to me! A few notes:

I did a manual test locally and it seems that it works well. Thank you!

@swt2c
Copy link
Contributor Author

swt2c commented Dec 6, 2022

On your first two bullets - yep, see #75

@nicoddemus
Copy link
Member

I suggest we just cherry-pick 8d722cb on top of #75 and merge that PR. 👍

@swt2c
Copy link
Contributor Author

swt2c commented Dec 6, 2022

Done.

@swt2c swt2c closed this Dec 6, 2022
@webknjaz
Copy link
Member

webknjaz commented Dec 6, 2022

GH action no longer supports Python 3.6, if you want to test with it, take a look at fedora-python/tox-github-action

FYI it is possible to get 3.6 in GHA if you set runs-on to an older Ubuntu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants