pytest-html is trying to encode my data inappropriately

[birdsarah]

I'm using:

• pytest-selenium 1.1
• pytest-html 1.7
• selenium 2.49.2

I get the following error on a test fail:

INTERNALERROR>     data = b64encode(content.encode(charset)).decode('ascii')
INTERNALERROR> AttributeError: 'bytes' object has no attribute 'encode'
> /Users/caged/miniconda3/envs/bokeh_34/lib/python3.4/site-packages/pytest_html-1.7-py3.4.egg/pytest_html/plugin.py(74)data_uri()
-> data = b64encode(content.encode(charset)).decode('ascii')


 72     def data_uri(content, mime_type='text/plain', charset='utf-8'):
 73         if PY3:
 74  ->         data = b64encode(content.encode(charset)).decode('ascii')
 75         else:
 76             data = b64encode(content)
 77         return 'data:{0};charset={1};base64,{2}'.format(mime_type, charset, data)

When in pdb, just running b64encode(content) works great - maybe PY3 check isn't quite right? Could we check what content is instead?

[davehunt]

@birdsarah could you paste more of your stack trace? I'm most interested in what content is, and where it's being provided. I assume this is one of the debug items from pytest-selenium but it's not clear which one. Note that pytest-selenium doesn't officially support Python 3.x, and it's possible it could be fixed there. That said, we probably want to support bytes objects in pytest-html too.

[davehunt]

I was able to replicate this, and have addressed it in #28. I am still interested in where this bytes object is being created though, if you could provide more information.

[davehunt]

My guess is that this is caused by pytest-selenium encoding here and here. This is necessary for Python 2.x but perhaps not for 3.x? @The-Compiler do you think this should be fixed in pytest-selenium to just pass the unicode object instead of encoding it first?

[The-Compiler]

As per the "unicode sandwich" concept (decode/encode at the borders, deal with unicode everywhere else), I think that'd make sense, yeah.

[davehunt]

Closing as the content should be encoded properly before sending it to pytest-html. I'll be fixing this in pytest-selenium.