-
Notifications
You must be signed in to change notification settings - Fork 243
Replace travis with github-actions #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would really appreciate a PR with some Github Actions! 😊 It would be awesome if you could comment it extensively to expedite the learning curve for me (and future contributors). Especially any tricks. 👍 |
+1 to @BeyondEvil's response |
I think we all seen how nice github actions works. Maybe is time to effectively drop Travis and switch the release to github actions. Less complexity can only help the project. @BeyondEvil @davehunt What do you think? I cannot do it myself because I do not have access to project settings or pypi. One needs to add project-specific-tokens for both pypi instances that look like: Ideally we should use a bot account for that, but I see none configured. You could reuse the |
Regarding the above, I think we should drop travis and move to github actions |
I'm happy to make the switch over to only using GHA. I also think using the pytest-dev bot is a good idea as long as project owners have the access they need to it. With that said, @davehunt has the final say. |
Don't let me get in the way of the using the best available tools. If you're all happy, I'm certainly not going to stop you. |
Where can I see the pytest-dev in use with GHA? @ssbarnea |
I need your pypi username @ssbarnea What's the username of the pytest-dev bot @nicoddemus ? Will I have access to it? Do I need access to it (to make it the release bot)? I guess (see below) I at least need the bot's API token. |
The bot right now doesn't have a user name on PyPI yet, there's been some discussion in pytest-dev/meta#4 but that has stalled. What I usually do is create a scoped token in my own account and use that; anyone with release rights on PyPI can create and replace that token if needed. |
Ah, got it. Thanks @nicoddemus 🙏 |
It looks like uploading to test pypi fails, @ssbarnea:
|
Maybe we can change the package name to be a pre release or devlopmental release identifier? |
I know what to do, I will do it tomorrow morning. Is the setuptools-scm config stuff. |
I created this in because I want to exemplify why I think in 2020, it makes more sense to use Github Action than Travis.
There is nothing preventing us from running both in parallel for a longer period of time, and even ignoring the results from one of them if we want.
I can easily raise a PTs I already did this for lots of repos and I know the tricks.
Update 2020-10
Changed scope from trying... to switching...
The text was updated successfully, but these errors were encountered: