Skip to content

Proper tests for qInfo when it becomes fully available #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicoddemus opened this issue Sep 1, 2018 · 3 comments
Closed

Proper tests for qInfo when it becomes fully available #232

nicoddemus opened this issue Sep 1, 2018 · 3 comments
Labels
infrastructure 💻

Comments

@nicoddemus
Copy link
Member

Followup to #225, qInfo is not currently exposed by the bindings. As suggested in #225 (comment), we can workaround that by using QMessageLogger, but sadly that's not exposed by PySide yet.

For now we can make a simple test for INFO messages, but when QMessageLogger is available (or even better qInfo) we should update the other tests to issue/capture INFO messages.
nicoddemus added a commit to nicoddemus/pytest-qt that referenced this issue Sep 1, 2018
@nicoddemus
Implement quick test to avoid regression on INFO log messages (pytest…
0835bc7 
…-dev#232)
nicoddemus added a commit to nicoddemus/pytest-qt that referenced this issue Sep 1, 2018
@nicoddemus
Implement quick test to avoid regression on INFO log messages (pytest…
2ec38df 
…-dev#232)
nicoddemus added a commit that referenced this issue Sep 13, 2018
@nicoddemus
Merge pull request #233 from nicoddemus/qinfo-tests
eaf09a7 
Implement quick test to avoid regression on INFO log messages (#232)
@The-Compiler
Copy link
Member

Closing this as the PR was merged. I also sent a mail to the PyQt mailinglist, so I'd expect it to show up in PyQt soon 😉

@nicoddemus
Copy link
Member Author

Thanks!

@The-Compiler
Copy link
Member

FWIW I got the usual "Should be in tonight's snapshot." answer, so qInfo() should be in PyQt 5.11.3, which is planned for after Qt 5.11.2, which in turn is planned the coming week or so 😉

penguinpee added a commit to penguinpee/pytest-qt that referenced this issue Mar 11, 2025
@penguinpee
Enable qInfo tests for PySide6
d8bb3d9 
PySide6 now exposes `qInfo` just like Qt6. This enables the `qInfo`
tests accordingly.

For reference see issue pytest-dev#232.
@penguinpee penguinpee mentioned this issue Mar 11, 2025
Merged
nicoddemus pushed a commit that referenced this issue Mar 11, 2025
@penguinpee
Enable qInfo tests for PySide6 (#593)
ce1a689 
PySide6 now exposes `qInfo` just like Qt6. This enables the `qInfo` tests accordingly.

For reference see issue #232.
The-Compiler added a commit that referenced this issue Mar 25, 2025
@The-Compiler
Revert "Enable qInfo tests for PySide6 (#593)"
a26733c 
This reverts commit ce1a689.

This change is incorrect as it breaks things with PySide < 6.8.2, but we support
running against older versions.

The next commit will fix this properly without breaking compatibility.

See #232
The-Compiler added a commit that referenced this issue Mar 25, 2025
@The-Compiler
tests: Make qInfo tests work with PySide6 6.8.2+
9c2e121 
qInfo() has been added:
https://codereview.qt-project.org/c/pyside/pyside-setup/+/605100

Follow-up / alternative to #593 without breaking compatibility with older
PySide6 versions. See #232.
The-Compiler added a commit that referenced this issue Mar 25, 2025
@The-Compiler
tests: Make qInfo tests work with PySide6 6.8.2+
40d237a 
qInfo() has been added:
https://codereview.qt-project.org/c/pyside/pyside-setup/+/605100

Follow-up / alternative to #593 without breaking compatibility with older
PySide6 versions. See #232.
The-Compiler added a commit that referenced this issue Mar 25, 2025
@The-Compiler
Revert "Enable qInfo tests for PySide6 (#593)"
3afa979 
This reverts commit ce1a689.

This change is incorrect as it breaks things with PySide < 6.8.2, but we support
running against older versions.

The next commit will fix this properly without breaking compatibility.

See #232
The-Compiler added a commit that referenced this issue Mar 25, 2025
@The-Compiler
tests: Make qInfo tests work with PySide6 6.8.2+
9d07374 
qInfo() has been added:
https://codereview.qt-project.org/c/pyside/pyside-setup/+/605100

Follow-up / alternative to #593 without breaking compatibility with older
PySide6 versions. See #232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure 💻
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@The-Compiler @nicoddemus