Skip to content

Give access to what arguments were passed with in the signal #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
billyshambrook opened this issue Jul 27, 2015 · 4 comments
Closed

Comments

@billyshambrook
Copy link

Thanks for the great plugin!

Would be awesome if when using qtbot.waitSignal, you could access any arguments that were sent in the signal e.g.

with qtbot.waitSignal(worker.success) as blocker:
    pass
assert blocker.args == 'hello, world!'

What are your thoughts?

I'll take a stab at it if you think it's a good feature, thanks

@The-Compiler
Copy link
Member

Sounds useful IMHO! You might want to use a QSignalSpy for that.

@nicoddemus
Copy link
Member

A PR with that would be very welcome, @billyshambrook! 😄

@nicoddemus nicoddemus changed the title Give access to what arguments where passed with in the signal Give access to what arguments were passed with in the signal Oct 15, 2015
@The-Compiler
Copy link
Member

I just needed that again yesterday, so I'll take a look at this.

@The-Compiler
Copy link
Member

See #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants