Skip to content

Use explicit try/finally to ensure loops quit when receiving a signal #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2015
Merged

Use explicit try/finally to ensure loops quit when receiving a signal #116

merged 3 commits into from
Dec 16, 2015

Conversation

nicoddemus
Copy link
Member

Fix #114

@The-Compiler
Copy link
Member

LGTM!

@nicoddemus
Copy link
Member Author

Also noticed that MultiSignalBlocker was not disconnecting its signals... 😱

@The-Compiler
Copy link
Member

I think in #71 (comment) we discovered it wasn't actually needed with MultiSignalBlocker but didn't figure out why - so I guess let's just do it now that you implemented it 😉

@nicoddemus
Copy link
Member Author

Hmm oh yeah, we kinda just let it go at that. Oh well, I think now everything is working as it should. 😄

nicoddemus added a commit that referenced this pull request Dec 16, 2015
@nicoddemus
Merge pull request #116 from pytest-dev/try-finally-quit
8d629a4 
Use explicit try/finally to ensure loops quit when receiving a signal
@nicoddemus nicoddemus merged commit 8d629a4 into master Dec 16, 2015
@nicoddemus nicoddemus deleted the try-finally-quit branch December 16, 2015 13:59
nicoddemus added a commit that referenced this pull request Dec 16, 2015
@nicoddemus
Update changelog with #114 and #116
3355bc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoddemus @The-Compiler