-
-
Notifications
You must be signed in to change notification settings - Fork 69
Support for capturing signals and args and improved SignalTimeoutError messages #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3f1a8a3
Added support for capturing arguments when callback was not satisfied…
NameZero912 23de0d1
Merge branch 'master' of https://github.com/pytest-dev/pytest-qt
NameZero912 77b1cb0
Added capturing signals and their arguments for MultiSignalBlocker (s…
NameZero912 78ecf73
Fixed several small issues.
NameZero912 061c11d
Try another fix. Apparently under Python 2.7 when using PyQt4, argume…
NameZero912 533e36b
Add some more tests regarding invalid user-provided parameters, to im…
NameZero912 9d64b1e
Improve formatting
NameZero912 2f20e6b
Add 3 more tests to further improve coverage.
NameZero912 6e18d47
Fixed an oversight.
NameZero912 875f941
Disable a test for Python 3.5 because functools.partial behavior chan…
NameZero912 2316261
Added NotImplementedError to base get_timeout_error_message(self) met…
NameZero912 56771f0
Fixed minor issues. Attempt to get coverage back to 100% using # prag…
NameZero912 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this guess for the next version actually correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 😁