Skip to content

Handle removal of MarkInfo in pytest 4.1.0 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

BeyondEvil
Copy link
Contributor

Fixes #206

@igortg
Copy link

igortg commented Jan 7, 2019

I was trying to update my selenium tests for pytest 4.1 this weekend. Thks for this update.

@nicoddemus
Copy link
Member

Thanks a lot @BeyondEvil, @igortg was about to make this PR himself. 😁

@pytest-dev/pytest-selenium-admin would appreciate if we can get a new release with this fix soon. 👍

Copy link
Contributor

@davehunt davehunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though I'd also accept a patch that updates the requirement to pytest 3.6 or later so we can just use iter_markers.

@nicoddemus
Copy link
Member

Looks fine, though I'd also accept a patch that updates the requirement to pytest 3.6 or later so we can just use iter_markers.

I agree, but I suggest to leave this for a future PR.

@davehunt could you please make a new release? 😁

@nicoddemus nicoddemus merged commit 047a9cc into pytest-dev:master Jan 7, 2019
@nicoddemus
Copy link
Member

#208

weeksghost pushed a commit to weeksghost/pytest-selenium that referenced this pull request May 4, 2019
@BeyondEvil BeyondEvil deleted the remove_markinfo_dep branch August 5, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants