Optional call for decorators #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
changed the title
|
@cdunklau, since you want this care to offer any opinions? I feel like |
altendky
commented
Jul 28, 2020
Comment on lines
+145
to
+170
| def _optional_arguments(): | ||
| def decorator_decorator(d): | ||
| # TODO: this should get the signature of d minus the f or something | ||
| def decorator_wrapper(*args, **decorator_arguments): | ||
| """this is decorator_wrapper""" | ||
| if len(args) > 1: | ||
| raise positional_not_allowed_exception() | ||
|
|
||
| if len(args) == 1: | ||
| maybe_f = args[0] | ||
|
|
||
| if len(decorator_arguments) > 0 or not callable(maybe_f): | ||
| raise positional_not_allowed_exception() | ||
|
|
||
| f = maybe_f | ||
| return d(f) | ||
|
|
||
| # TODO: this should get the signature of d minus the kwargs | ||
| def decorator_closure_on_arguments(f): | ||
| return d(f, **decorator_arguments) | ||
|
|
||
| return decorator_closure_on_arguments | ||
|
|
||
| return decorator_wrapper | ||
|
|
||
| return decorator_decorator |
There was a problem hiding this comment.
This is basically just @decorator.decorator...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I give in...
Draft for:
@decorator.decorator