-
Notifications
You must be signed in to change notification settings - Fork 22
Update testing etc for Python 3.8 #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6cd9667
Update testing etc for Python 3.8
altendky 57003d6
Merge branch 'master' into py38
altendky 0a11d88
Merge branch 'master' into py38
altendky 33a1d1a
Update appveyor.yml
altendky c6eff3d
Use asyncio.WindowsSelectorEventLoopPolicy for 3.8+
altendky adb46b6
Update pytest_twisted.py
altendky d5f5bf8
Update pytest_twisted.py
altendky 84fd407
Update pytest_twisted.py
altendky 54bfe45
Merge branch 'master' into py38
altendky 08bc017
remove asyncio.WindowsSelectorEventLoopPolicy attempt
altendky 277a4e9
Use asyncio.WindowsSelectorEventLoopPolicy() for applicable tests
altendky c0c9a15
Trying again for asyncio on windows on py38
altendky 5e84a28
add missing trailing newline
altendky 0bdf552
Add notes about py3.8/asyncio/proactor to readme
altendky 41ba6e2
Make the proactor helper _private for now
altendky 39f9fbb
Merge branch 'master' into py38
altendky 22fd7c5
Add CPython 3.8 to GitHub Actions
altendky 44130c8
remove whitespace from blank lines
altendky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,9 @@ matrix: | |
- python: 3.7 | ||
dist: xenial | ||
sudo: true | ||
- python: 3.8 | ||
dist: xenial | ||
sudo: true | ||
|
||
addons: | ||
apt: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,10 @@ | ||
import pytest | ||
import pytest_twisted | ||
|
||
|
||
pytest_plugins = "_pytest.pytester" | ||
|
||
|
||
@pytest.hookimpl(tryfirst=True) | ||
def pytest_configure(config): | ||
pytest_twisted.use_asyncio_selector_if_required(config=config) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm writing up some docs on the topic too (and fixed the missing trailing newline) but it feels like there's some thing to provide users with that isn't copy/paste. But, this isn't a
pytest-twisted
issue... and it could be run regardless of version. I can't decide how I feel about this.