-
Notifications
You must be signed in to change notification settings - Fork 24
[WIP] Dependent async fixture failures #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Dependent async fixture failures #90
Conversation
I don't have anything remotely working but I do think I'm on a useful path that will be much more correct to pytest. |
Would you like me to commandeer this branch and PR tomorrow? Or make my own. |
Feel free to commandeer. I was going to just write a bug report, but I had already written the reproduction.
… On 1. Mar 2020, at 06:51, Kyle Altendorf ***@***.***> wrote:
Would you like me to commandeer this branch and PR tomorrow? Or make my own.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Oh yeah, you could just branch off this and PR against my PR. That's probably cleaner. |
Hmm, so the issue isn't just when you return/yield a function from the parent fixture, it's overall. Will add more (simpler) tests. |
I don't really see the usefulness of the more complex tests. They should probably be removed. |
I had the new tests passing. I'm not totally sure what I'm doing but I think I just need to get the teardown for async yield fixtures working again. I'm thinking this might also allow for non-function scope async fixtures... But I haven't tested anything in that direction yet. |
Pushed my first effort in #91 |
It looks like using an async fixture in another async fixture doesn't work. Here are some tests that show the problem. cc @altendky