pytest.exit causes internal error

[RonnyPfannschmidt]

based on pytest-dev/pytest#13667 (comment)

it seems a pytest.exit is not properly handled

[0z0sk0]

Hi! According to my observations, xdist correctly handles exceptions only with pytest.exit with exit code 0, in other cases it is processed as INTERNALERROR and does not provide any useful information. The same situation if we leave the exception unhandled and leave it xdist.

For example:

stacktrace with pytest.exit EXITCODE=pytest.ExitCode.INTERNAL_ERROR or another defined, not 0:

1 worker [858 items] 1 error                                                                                                                                                                                                                                                                                       
EINTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\_pytest\main.py", line 283, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>                          ~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\_pytest\main.py", line 337, in _main
INTERNALERROR>     config.hook.pytest_runtestloop(session=session)
INTERNALERROR>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\pluggy\_hooks.py", line 513, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\pluggy\_manager.py", line 120, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\pluggy\_callers.py", line 139, in _multicall
INTERNALERROR>     raise exception.with_traceback(exception.__traceback__)
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\pluggy\_callers.py", line 122, in _multicall
INTERNALERROR>     teardown.throw(exception)  # type: ignore[union-attr]
INTERNALERROR>     ~~~~~~~~~~~~~~^^^^^^^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\_pytest\logging.py", line 803, in pytest_runtestloop
INTERNALERROR>     return (yield)  # Run all the tests.
INTERNALERROR>             ^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\pluggy\_callers.py", line 122, in _multicall
INTERNALERROR>     teardown.throw(exception)  # type: ignore[union-attr]
INTERNALERROR>     ~~~~~~~~~~~~~~^^^^^^^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\_pytest\terminal.py", line 673, in pytest_runtestloop
INTERNALERROR>     result = yield
INTERNALERROR>              ^^^^^
INTERNALERROR>   File "C:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\pluggy\_callers.py", line 103, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "c:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\xdist\dsession.py", line 138, in pytest_runtestloop
INTERNALERROR>     self.loop_once()
INTERNALERROR>     ~~~~~~~~~~~~~~^^
INTERNALERROR>   File "c:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\xdist\dsession.py", line 163, in loop_once
INTERNALERROR>     call(**kwargs)
INTERNALERROR>     ~~~~^^^^^^^^^^
INTERNALERROR>   File "c:\Users\anatolii.shevchuk\git\test\.venv\Lib\site-packages\xdist\dsession.py", line 217, in worker_workerfinished
INTERNALERROR>     assert not crashitem, (crashitem, node)
INTERNALERROR> AssertionError: ('tests/test_function.py::TestFunction::test_syntax[ABCD]', <WorkerController gw0>)
INTERNALERROR> assert not 'tests/test_function.py::TestFunction::test_syntax[ABCD]'

[0z0sk0]

and btw, my method with the exit described above (with exitcode 0) outputs an incorrect exitcode for the worker (it is always keyboard-interrupt)

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! xdist.dsession.Interrupted: <WorkerController gw0> received keyboard-interrupt !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 
================================================================================================================================ 1 failed, 1 warning, 6 errors in 65.87s (0:01:05) ================================================================================================================================