Skip to content

Add worker_id into TestReport #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

KKoukiou
Copy link
Contributor

I think this change is enough for the purpose of this issue
Though, I am not really familiar with the project, so please let me know if I am missing something.

@RonnyPfannschmidt
Copy link
Member

good work

based on

elif eventname in (

and
def unserialize_report(name, reportdict):
if name == "testreport":
return runner.TestReport(**reportdict)
elif name == "collectreport":
return runner.CollectReport(**reportdict)

this change is good,
do you think you can add a test for it without too much effort ?

@nicoddemus
Copy link
Member

Could you also add a new changelog entry and perhaps add a note to the README about this new feature?

@KKoukiou
Copy link
Contributor Author

@RonnyPfannschmidt @nicoddemus thanks for the feedback. I 'll adjust the patch and resend with your comments!

@KKoukiou KKoukiou force-pushed the worker_id branch 2 times, most recently from 7ed214e to faa1c2e Compare February 14, 2017 12:02
@RonnyPfannschmidt RonnyPfannschmidt merged commit f3098f0 into pytest-dev:master Feb 16, 2017
@nicoddemus
Copy link
Member

@RonnyPfannschmidt could you at least add a CHANGELOG entry?

@RonnyPfannschmidt
Copy link
Member

@nicoddemus there is one already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants