Repository navigation
marks should propogate through fixtures #2399
Description
Example code below. Expected output: passing tests. Actual output, AssertionError.
import pytest
@pytest.fixture(scope='function', autouse=True)
def db_rollback(request):
assert request.node.get_marker('db_rollback_exempt')
@pytest.fixture(scope='function')
@pytest.mark.db_rollback_exempt
def context():
return True
def test_foo(context):
assert True
Activity
RonnyPfannschmidt commentedon May 10, 2017
in #977 we already documented that this doesn't work
there are 2 problems keeping it that way
a) in any more complex fixture setup its completely unclear in what way to propagate marks, nobody sat down and made a reasonably complete proposal (that includes parametrisation)
b) the current implementation of marks and mark propagation is completely misfit for such a feature and would need a relatively large restructuring/rewrite
nicoddemus commentedon May 10, 2017
Should we close this then, or keep it open for reference?
RonnyPfannschmidt commentedon May 10, 2017
@nicoddemus i'd like to decide after feedback from @majuscule
majuscule commentedon May 10, 2017
Hi @RonnyPfannschmidt, @nicoddemus, thanks for the quick response. I'd like to keep this open as a feature request. Can you give an example of a complex fixture design (possibly with parametrization) that makes this difficult? I'm thinking that a mark should simply be inherited by any function that the marked fixture is provided to.
RonnyPfannschmidt commentedon May 14, 2017
oh, also im closing thos one as a duplicate of #1368