Skip to content

Transition open PRs from the features branch to master #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bluetech opened this issue Feb 12, 2020 · 8 comments
Closed

Transition open PRs from the features branch to master #6719

bluetech opened this issue Feb 12, 2020 · 8 comments
Labels
type: infrastructure improvement to development/releases/CI structure

Comments

@bluetech
Copy link
Member

As part of #6571, we want to delete the features branch, but there are some open PRs against it. This is the list: https://github.com/pytest-dev/pytest/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+base%3Afeatures

I've asked all of the submitters to rebase on master. Once the list becomes empty, we can do the deletion.

@Zac-HD Zac-HD added the type: infrastructure improvement to development/releases/CI structure label Feb 13, 2020
@nicoddemus
Copy link
Member

Thanks, I like how you took the time to write a short message to each PR. 👍

@nicoddemus
Copy link
Member

Btw we might consider just changing the target of the PRs ourselves, that's what I did in #6410 and didn't have any repercussions there.

@bluetech
Copy link
Member Author

I thought I'd give the authors a chance to do it themselves, but after some time we can switch it ourselves. ATM there are 4 PRs left.

@nicoddemus
Copy link
Member

Sounds good, should we give ourselves a "deadline"? How about Monday?

@bluetech
Copy link
Member Author

Fine by me!

@bluetech
Copy link
Member Author

@nicoddemus Oops, I remembered Sunday but you said Monday. Anyway, I've changed the remaning PRs manually and the list is clear now.

@nicoddemus
Copy link
Member

No problem, all good then. 👍

@nicoddemus
Copy link
Member

Just deleted features (was 4209ad6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Development

No branches or pull requests

3 participants