WIP hack around mark object [skip ci] #6410
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @RonnyPfannschmidt,
The topic of mark objects came up at work again, and I decided to be a bit of hacking to see how far I could get based on the discussion in #5424.
I basically removed some checks and made
MarkDecorator
callable, so this is possible:No registration necessary, just a plain object with the only restriction that it needs to have a
name: str
attribute (which can also be lifted easily).Wanted to share because I'm excited that this was possible with so little work (thanks to all the previous work you've done here of course).