test_cmdline_python_package() fails #74

pytestbot · 2011-09-25T05:02:58Z

Originally reported by: Arfrever Frehtes Taifersar Arahesis (BitBucket: arfrever, GitHub: arfrever)

test_cmdline_python_package() from testing/acceptance_test.py fails at least with CPython 2.6 and 2.7. It passes with CPython 3.1 and 3.2.

$ py.test-2.7 testing/acceptance_test.py
==================================================================== test session starts ====================================================================
platform linux2 -- Python 2.7.3 -- pytest-2.1.2
collected 38 items 

testing/acceptance_test.py ..................................F.x.

========================================================================= FAILURES ==========================================================================
____________________________________________________ TestInvocationVariants.test_cmdline_python_package _____________________________________________________

self = <acceptance_test.TestInvocationVariants instance at 0x2da3098>
testdir = <TmpTestdir local('/tmp/pytest-0/testdir/test_cmdline_python_package0/test_cmdline_python_package')>
monkeypatch = <_pytest.monkeypatch.monkeypatch instance at 0x2da3320>

    def test_cmdline_python_package(self, testdir, monkeypatch):
        monkeypatch.delenv('PYTHONDONTWRITEBYTECODE', False)
        path = testdir.mkpydir("tpkg")
        path.join("test_hello.py").write("def test_hello(): pass")
        path.join("test_world.py").write("def test_world(): pass")
        result = testdir.runpytest("--pyargs", "tpkg")
        assert result.ret == 0
        result.stdout.fnmatch_lines([
            "*2 passed*"
        ])
        result = testdir.runpytest("--pyargs", "tpkg.test_hello")
        assert result.ret == 0
        result.stdout.fnmatch_lines([
            "*1 passed*"
        ])
        result = testdir.runpytest("--pyargs", ".")
        assert result.ret == 0
        result.stdout.fnmatch_lines([
>           "*2 passed*"
E           Failed: remains unmatched: '*2 passed*', see stderr

/tmp/pytest-2.1.2/testing/acceptance_test.py:409: Failed
---------------------------------------------------------------------- Captured stdout ----------------------------------------------------------------------
running ['/usr/bin/python2.7', '/usr/lib64/python2.7/site-packages/pytest.py', '--basetemp=/tmp/pytest-0/testdir/test_cmdline_python_package0/test_cmdline_python_package/runpytest-0', '--pyargs', 'tpkg'] curdir= /tmp/pytest-0/testdir/test_cmdline_python_package0/test_cmdline_python_package
============================= test session starts ==============================
platform linux2 -- Python 2.7.3 -- pytest-2.1.2
collecting ... collected 2 items

tpkg/test_hello.py .
tpkg/test_world.py .

=========================== 2 passed in 0.02 seconds ===========================
running ['/usr/bin/python2.7', '/usr/lib64/python2.7/site-packages/pytest.py', '--basetemp=/tmp/pytest-0/testdir/test_cmdline_python_package0/test_cmdline_python_package/runpytest-1', '--pyargs', 'tpkg.test_hello'] curdir= /tmp/pytest-0/testdir/test_cmdline_python_package0/test_cmdline_python_package
============================= test session starts ==============================
platform linux2 -- Python 2.7.3 -- pytest-2.1.2
collecting ... collected 1 items

tpkg/test_hello.py .

=========================== 1 passed in 0.01 seconds ===========================
running ['/usr/bin/python2.7', '/usr/lib64/python2.7/site-packages/pytest.py', '--basetemp=/tmp/pytest-0/testdir/test_cmdline_python_package0/test_cmdline_python_package/runpytest-2', '--pyargs', '.'] curdir= /tmp/pytest-0/testdir/test_cmdline_python_package0/test_cmdline_python_package
============================= test session starts ==============================
platform linux2 -- Python 2.7.3 -- pytest-2.1.2
collecting ... collected 0 items

===============================  in 0.17 seconds ===============================
---------------------------------------------------------------------- Captured stderr ----------------------------------------------------------------------
nomatch: '*2 passed*'
    and: u'============================= test session starts =============================='
    and: u'platform linux2 -- Python 2.7.3 -- pytest-2.1.2'
    and: u'collecting ... collected 2 items'
    and: u''
    and: u'tpkg/test_hello.py .'
    and: u'tpkg/test_world.py .'
    and: u''
fnmatch: '*2 passed*'
   with: u'=========================== 2 passed in 0.02 seconds ==========================='
nomatch: '*1 passed*'
    and: u'============================= test session starts =============================='
    and: u'platform linux2 -- Python 2.7.3 -- pytest-2.1.2'
    and: u'collecting ... collected 1 items'
    and: u''
    and: u'tpkg/test_hello.py .'
    and: u''
fnmatch: '*1 passed*'
   with: u'=========================== 1 passed in 0.01 seconds ==========================='
nomatch: '*2 passed*'
    and: u'============================= test session starts =============================='
    and: u'platform linux2 -- Python 2.7.3 -- pytest-2.1.2'
    and: u'collecting ... collected 0 items'
    and: u''
    and: u'===============================  in 0.17 seconds ==============================='
====================================================== 1 failed, 36 passed, 1 xfailed in 53.20 seconds ======================================================

Bitbucket: https://bitbucket.org/pytest-dev/pytest/issue/74

The text was updated successfully, but these errors were encountered:

pytestbot · 2011-09-25T05:15:48Z

Original comment by holger krekel (BitBucket: hpk42, GitHub: hpk42):

This neither fails in my develop laptop nor in the CI system, see e.g. http://hudson.testrun.org/view/pytest/job/pytest/TOXENV=py27,label=linux/352/console

so i wonder what the problem is. Could you try to track it down a bit more? And, failing that, provide more platform information?

pytestbot · 2011-09-25T06:18:47Z

Original comment by Arfrever Frehtes Taifersar Arahesis (BitBucket: arfrever, GitHub: arfrever):

This patch fixes test failure for me:
{{{
--- testing/acceptance_test.py
+++ testing/acceptance_test.py
@@ -403,7 +403,7 @@
result.stdout.fnmatch_lines([
"1 passed"
])

   result = testdir.runpytest("--pyargs", ".")

   result = testdir.runpytest(".")
 assert result.ret == 0
 result.stdout.fnmatch_lines([
     "_2 passed_"

}}}

The fact that this test failure hasn't occurred with CPython 3 might indicate that there is another bug.

pytestbot · 2011-09-25T06:25:35Z

Original comment by Arfrever Frehtes Taifersar Arahesis (BitBucket: arfrever, GitHub: arfrever):

See differences in number of collected items:
{{{
$ mkdir /tmp/pytest_tests
$ cd /tmp/pytest_tests
$ echo 'def test(): pass' > test_something.py
$ py.test-2.7 .
==================================================================== test session starts ====================================================================
platform linux2 -- Python 2.7.3 -- pytest-2.1.2
collected 1 items

test_something.py .

================================================================= 1 passed in 0.01 seconds ==================================================================
$ py.test-2.7 --pyargs .
==================================================================== test session starts ====================================================================
platform linux2 -- Python 2.7.3 -- pytest-2.1.2
collected 0 items

===================================================================== in 0.17 seconds ======================================================================
$ py.test-3.2 .
==================================================================== test session starts ====================================================================
platform linux2 -- Python 3.2.3 -- pytest-2.1.2
collected 1 items

test_something.py .

================================================================= 1 passed in 0.02 seconds ==================================================================
$ py.test-3.2 --pyargs .
==================================================================== test session starts ====================================================================
platform linux2 -- Python 3.2.3 -- pytest-2.1.2
collected 1 items

test_something.py .

================================================================= 1 passed in 0.02 seconds ==================================================================
}}}

pytestbot · 2011-09-25T06:26:45Z

Original comment by holger krekel (BitBucket: hpk42, GitHub: hpk42):

But this is about testing the "--pyargs" argument so removing it does not help. Like i said, for me this test passes everywhere and i'd like to understand why it fails on your machine.

pytestbot · 2011-09-25T08:07:54Z

Original comment by Arfrever Frehtes Taifersar Arahesis (BitBucket: arfrever, GitHub: arfrever):

This problem occurs when there is a directory on sys.path and with init.py file.

{{{
$ mkdir /tmp/something
$ touch /tmp/something/init.py
$ PYTHONPATH="/tmp/something" py.test-2.7 testing/acceptance_test.py
...
}}}

_pytest.main.Session._tryconvertpyarg() maybe should more intelligently handle x==".". If x is ".", then x.split('.') returns ['', ''], so the loop iterates twice on the same string.

pytestbot · 2011-09-25T08:38:18Z

Original comment by Ronny Pfannschmidt (BitBucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt):

i also fails for me, when running with pytest instead of tox

pytestbot · 2011-09-25T08:44:08Z

Original comment by Arfrever Frehtes Taifersar Arahesis (BitBucket: arfrever, GitHub: arfrever):

New patch:
{{{
--- _pytest/main.py
+++ _pytest/main.py
@@ -470,8 +470,13 @@

 def _tryconvertpyarg(self, x):
     mod = None

   path = [os.path.abspath('.')] + sys.path

```
   for name in x.split('.'):
```
```
   if x == '.':
```
```
       path = [os.path.abspath('.')]
```
```
       names = ['']
```
```
   else:
```

       path = [os.path.abspath('.')] + sys.path

```
       names = x.split('.')
```

   for name in names:
     try:
         fd, mod, type_ = imp.find_module(name, path)
     except ImportError:

}}}

pytestbot · 2011-10-26T20:45:02Z

Original comment by Ronny Pfannschmidt (BitBucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt):

fix issue74 - propperly filter out missfit names in _tryconvertpyarg

pytestbot · 2011-10-26T21:33:21Z

Original comment by Arfrever Frehtes Taifersar Arahesis (BitBucket: arfrever, GitHub: arfrever):

The test doesn't fail with previous code in _pytest/main.py.
{{{
--- testing/acceptance_test.py
+++ testing/acceptance_test.py
@@ -409,13 +409,14 @@
"2 passed"
])

   empty_package = testdir.mkpydir("empty_package")

   monkeypatch.setenv('PYTHONPATH', empty_package)
 result = testdir.runpytest("--pyargs", ".")
 assert result.ret == 0
 result.stdout.fnmatch_lines([
     "*2 passed*"
 ])

   monkeypatch.setenv('PYTHONPATH', testdir)
 path.join('test_hello.py').remove()
 result = testdir.runpytest("--pyargs", "tpkg.test_hello")
 assert result.ret != 0

}}}

pytestbot · 2011-10-26T22:02:14Z

Original comment by Ronny Pfannschmidt (BitBucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt):

tests fixed on current default

…herwise Fixes pytest-dev#74

Fix All The Things

pytestbot added the type: bug problem that needs to be addressed label Jun 15, 2015

pytestbot closed this as completed Jun 15, 2015

pytestbot mentioned this issue Mar 18, 2018

capsys fails for subprocess calls #3319

Closed

pytestbot mentioned this issue Apr 10, 2018

How to intercept setup_module and setup_class when it fails from own plugin file #3378

Closed

pytestbot mentioned this issue Jun 10, 2018

TestRequestBasic.test_request_garbage sometimes fails on AppVeyor #3564

Closed

pytestbot mentioned this issue Jun 28, 2018

get_type_hints() fails on Mark.__init__ #3635

Closed

fkohlgrueber pushed a commit to fkohlgrueber/pytest that referenced this issue Oct 27, 2018

Allow up to two empty lines on module level and single empty lines ot…

e5f8251

…herwise Fixes pytest-dev#74

The-Compiler mentioned this issue Jan 17, 2020

[RFC] Use -rfE by default? (reportchars) #6454

Closed

This was referenced Mar 28, 2023

Pytest assert rewrite fails when rewriting some parts of cassandra cython code #10844

Open

Pytest assert rewrite causes serialzation problem with dill #10845

Closed

mgorny pushed a commit to mgorny/pytest that referenced this issue May 27, 2023

Merge pull request pytest-dev#74 from manahl/bugfix/fix-tests

d1c67c4

Fix All The Things

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test_cmdline_python_package() fails #74

test_cmdline_python_package() fails #74

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Oct 26, 2011

pytestbot commented Oct 26, 2011

pytestbot commented Oct 26, 2011

test_cmdline_python_package() fails #74

test_cmdline_python_package() fails #74

Comments

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Sep 25, 2011

pytestbot commented Oct 26, 2011

pytestbot commented Oct 26, 2011

pytestbot commented Oct 26, 2011