ImportPathMismatchError when on UNC path

[htgoebel]

Windows: When running pytest on a directory mounted as UNC path, this fail with ImportPathMismatchError:

c:\vagrant>pytest tests\\functional\\test_path_encodings.py
pytest tests\\functional\\test_path_encodings.py
Adding c:\python38\lib\site-packages\pywin32_system32 to sys.path
ImportError while loading conftest 'c:\vagrant\tests\functional\conftest.py'.
_pytest.pathlib.ImportPathMismatchError: ('conftest', 'c:\\vagrant\\tests\\functional\\conftest.py', WindowsPath('c:/vagrant/tests/functional/conftest.py'))

How to reproduce

• Fire up a virtual maschine usine Vagrat and sharing the current directory (which contains the package)
• Intall Python, pytest and requiremnets
• Try running pytest

You can actually use the setup provided by PyInstaller:

git clone https://github.com/pyinstaller/pyinstaller.git
cd bootloader
# in Vagrantfile, line 434 (provision step "install packages") remove "vcbuildtools"
# … to save avoid installing this huge package
vagrant up --no-provision windows10
vagrant ssh windows10  # password is "Passw0rd!"
pip install -U pip
python -m pip install --upgrade pip setuptools wheel
pip install -U -r tests/requirements-tools.txt
pip install -e .
pytest tests/functional/test_path_encodings.py

C:\Users\IEUser>pip list
Package Version Location

---

altgraph 0.17
apipkg 1.5
atomicwrites 1.4.0
attrs 20.1.0
colorama 0.4.3
execnet 1.7.1
flake8 3.8.3
future 0.18.2
iniconfig 1.0.1
lxml 4.5.2
mccabe 0.6.1
more-itertools 8.4.0
packaging 20.4
pefile 2019.4.18
pip 20.2.2
pluggy 0.13.1
psutil 5.7.2
py 1.9.0
pycodestyle 2.6.0
pyflakes 2.2.0
pyinstaller 4.1.dev0 \vboxsvr\vagrant
pyinstaller-hooks-contrib 2020.7
pyparsing 2.4.7
pytest 6.0.1
pytest-drop-dup-tests 0.3.0
pytest-forked 1.3.0
pytest-timeout 1.4.2
pytest-xdist 2.0.0
pywin32 228
pywin32-ctypes 0.2.0
setuptools 47.1.0
six 1.15.0
tinyaes 1.0.1
toml 0.10.1

System: Windows10, Python 3.8.5

[htgoebel]

Addendum: This issue also occurs when running tests via cmd.exe.

[echarrod]

Looks like I'm also getting this with pytest 6.0.0

[echarrod]

I Just tried with pytest 5.4.3 & 5.3.5, and get the same error, so not sure if it is a problem with pytest

[nicoddemus]

Hi @htgoebel,

Sorry for the delay.

You can actually use the setup provided by PyInstaller

Thanks a lot for the detailed and reproducible example, however I'm having trouble with Vagrant on my computer so those steps are not working for me right now (it gives an error trying to rsync the internal paths).

Looking at the error message, the cause of the problem is the os.path.samefile call in this block:

pytest/src/_pytest/pathlib.py

Lines 523 to 537 in 634cde9

	ignore = os.environ.get("PY_IGNORE_IMPORTMISMATCH", "")
	if ignore != "1":
	module_file = mod.__file__
	if module_file.endswith((".pyc", ".pyo")):
	module_file = module_file[:-1]
	if module_file.endswith(os.path.sep + "__init__.py"):
	module_file = module_file[: -(len(os.path.sep + "__init__.py"))]
	try:
	is_same = os.path.samefile(str(path), module_file)
	except FileNotFoundError:
	is_same = False
	if not is_same:
	raise ImportPathMismatchError(module_name, module_file, path)

So can you please try:

1. Set PY_IGNORE_IMPORTMISMATCH=1. This is a escape hatch of this mismatch mechanism, this should make the problem go away.

2. Can you try this branch: https://github.com/nicoddemus/pytest/tree/same-path-unc-7678? Installing it directly together with the editable install should do the trick:

   pip install -e . git+https://github.com/nicoddemus/pytest@same-path-unc-7678
   

   If this works, I will introduce that fix into pytest itself.

Thanks!

[nicoddemus]

@echarrod

I Just tried with pytest 5.4.3 & 5.3.5, and get the same error, so not sure if it is a problem with pytest

You mean "it is a problem with pytest", correct?

[echarrod]

I was actually thinking that

@echarrod

I Just tried with pytest 5.4.3 & 5.3.5, and get the same error, so not sure if it is a problem with pytest

You mean "it is a problem with pytest", correct?

I was actually thinking that because I rolled back, that it was not pytest, as I remember these versions working previously.

[echarrod]

I tried the steps:

Set PY_IGNORE_IMPORTMISMATCH=1
pip install -e . git+https://github.com/nicoddemus/pytest@same-path-unc-7678

I am getting the following error, but I'm unsure if this is a problem with my environment, or pytest:

C:\Users\username\repos\my-repo>pytest
Traceback (most recent call last):
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\username\AppData\Local\Programs\Python\Python38-32\Scripts\pytest.exe\__main__.py", line 7, in <module>
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\_pytest\config\__init__.py", line 185, in console_main
    code = main()
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\_pytest\config\__init__.py", line 141, in main
    config = _prepareconfig(args, plugins)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\_pytest\config\__init__.py", line 316, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\manager.py", line 84, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\callers.py", line 203, in _multicall
    gen.send(outcome)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\_pytest\helpconfig.py", line 100, in pytest_cmdline_parse
    config = outcome.get_result()  # type: Config
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\_pytest\config\__init__.py", line 998, in pytest_cmdline_parse
    self.parse(args)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\_pytest\config\__init__.py", line 1272, in parse
    self._preparse(args, addopts=addopts)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\_pytest\config\__init__.py", line 1177, in _preparse
    self.hook.pytest_load_initial_conftests(
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\manager.py", line 84, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\callers.py", line 208, in _multicall
    return outcome.get_result()
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pluggy\callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "c:\users\username\appdata\local\programs\python\python38-32\lib\site-packages\pytest_cov\plugin.py", line 124, in pytest_load_initial_conftests
    if early_config.known_args_namespace.cov_source:
AttributeError: 'Namespace' object has no attribute 'cov_source'

[echarrod]

I reinstalled everything, and deleted the build folder, and it's now working. So I am using pytest 6.0.1, not the one from the branch, but still the PY_IGNORE_IMPORTMISMATCH=1 is set

[htgoebel]

@nicoddemus I'll try this, but it will take a few day until I find time for.

[nicoddemus]

@echarrod

I am getting the following error, but I'm unsure if this is a problem with my environment, or pytest:

Argh, unfortunately this is an incompatibility on existing master with pytest-cov. We already have a fix that that should be merged in soon: #7721.

but still the PY_IGNORE_IMPORTMISMATCH=1 is set

Thanks for confirming. 👍

@htgoebel

@nicoddemus I'll try this, but it will take a few day until I find time for.

No worries, thanks! I see your https://github.com/pyinstaller/pyinstaller/blob/develop/tests/requirements-tools.txt does not include pytest-cov, so you won't run into the issue I mentioned above.

[nicoddemus]

@htgoebel

Just to be clear: setting PY_IGNORE_IMPORTMISMATCH=1 should fix your problem right away, but I would appreciate if you could test my branch without PY_IGNORE_IMPORTMISMATCH being set, so I can incorporate the fix into pytest. 👍