Skip to content

String difference gets hidden without -vv #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
The-Compiler opened this issue Aug 11, 2015 · 3 comments
Closed

String difference gets hidden without -vv #934

The-Compiler opened this issue Aug 11, 2015 · 3 comments
Labels
topic: reporting related to terminal output and user-facing messages and errors

Comments

@The-Compiler
Copy link
Member

I just had a test failure like this:

str1 = """header:
    <line 1>
    <line 2>
    <this is some longer line which should not be here>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <line 3>"""

str2 = """header:
    <line 1>
    <line 2>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <a lot of more lines so -vv is required>
    <line 3>"""

def test_same():
    assert str1 == str2

Without running with -vv, it's not really apparent where the issue is:

    def test_same():
>       assert str1 == str2
E       assert 'header:\n   ...n    <line 3>' == 'header:\n    ...n    <line 3>'
E         Detailed information truncated, use "-vv" to show

At least some context should probably be shown, similar to what happens without the extra lines:

    def test_same():
>       assert str1 == str2
E       assert 'header:\n   ...n    <line 3>' == 'header:\n    ...n    <line 3>'
E           header:
E               <line 1>
E               <line 2>
E         -     <this is some longer line which should not be here>
E               <line 3>
@nicoddemus
Copy link
Member

Agree, thanks for reporting Florian. 😄

@nicoddemus nicoddemus added the topic: reporting related to terminal output and user-facing messages and errors label Aug 11, 2015
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Aug 28, 2015
@flub flub closed this as completed in #978 Aug 28, 2015
@eric-wieser
Copy link

This only shows the first lines, which is not enough if the error is in the last line

@nicoddemus
Copy link
Member

@eric-wieser thanks for the comment. Would you mind opening a new issue so we can track it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: reporting related to terminal output and user-facing messages and errors
Projects
None yet
Development

No branches or pull requests

3 participants