-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Rename internal "warnings" in the terminal output to "pytest-warnings" #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👍 |
FWIW, 👍 from me as well |
I came here trying to find about "pytest-warnings" which were throwing me off. I've never seen those and something like a one line saying: "N pytest-warnings found, to get a report use $flags" |
For what it's worth, "pytest-warnings" doesn't help make this more obvious for me. I'm running my own unit tests, so when I see something that says "warning" and turns yellow, I immediately blame my code. I think it would be really helpful if anything that caused an internal warning or error provided some output by default. After passing -rw I end up with a message like: ...which makes it immediately obvious that it's not an issue with my code. |
@bhearsum I agree... I'm thinking that ideally |
I also ended up here after spending a few baffled minutes trying to figure out why my results were yellow and trying every mechanism I knew for coaxing more output out of pytest ( |
Any plans to fix this annoying issue? I really hate adding confusion to anyone that is trying to read the logs. |
@ssbarnea this is fixed since last year and is released since a while |
I am using the latest version pytest and I do still see these warnings which are confusing. I guess we are talking about different issues. My issue is that I see I just don't want to have non-actionable warnings in the build logs because they are toxic.
|
@ssbarnea in pytest-3.0 now the warnings are displayed by default. |
@ssbarnea Note that you can pass |
Currently when the a suite contains internal warnings (such as classes starting with "Test" but containing a
__init__
method) produce output like this:In my experience, this is confusing for most users when they first see this, as they think the test suite is producing warnings from the builtin
warnings
module.How about if we rename "warnings" to "pytest-warnings"?
I think most users will immediately understand that the warnings are related to pytest, and not from their code.
The text was updated successfully, but these errors were encountered: