[pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/psf/black: 22.10.0 → 22.12.0
• github.com/asottile/pyupgrade: v3.3.0 → v3.3.1

[nicoddemus]

Strange, readthedocs failed with:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/sphinx/events.py", line 94, in emit
    results.append(listener.handler(self.app, *args))
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/pallets_sphinx_themes/theme_check.py", line 46, in wrapped
    return f(app, *args, **kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/pallets_sphinx_themes/versions.py", line 14, in load_versions
    versions = readthedocs_versions(app)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/pallets_sphinx_themes/versions.py", line 79, in readthedocs_versions
    DocVersion(name=name, slug=slug, dev=dev, current=slug == current_slug)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/pallets_sphinx_themes/versions.py", line 116, in __new__
    version = pv.parse(slug)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/packaging/version.py", line 52, in parse
    return Version(version)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/packaging/version.py", line 197, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: 'latest'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/sphinx/application.py", line 262, in __init__
    self._init_builder()
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/sphinx/application.py", line 335, in _init_builder
    self.events.emit('builder-inited')
  File "/home/docs/checkouts/readthedocs.org/user_builds/pytest/envs/10578/lib/python3.9/site-packages/sphinx/events.py", line 105, in emit
    raise ExtensionError(__("Handler %r for event %r threw an exception") %
sphinx.errors.ExtensionError: Handler <function load_versions at 0x7f39202c0820> for event 'builder-inited' threw an exception (exception: Invalid version: 'latest')

It is not related with tox at all, does anybody has an idea of what might be the problem?

[RonnyPfannschmidt]

the issue is entirely new - "latest" is not something we use in our code

[RonnyPfannschmidt]

@nicoddemus identified /pallets_sphinx_themes/versions.py", line 116, in __new__

i suspect a recent packaging release with removal of loose version triggers the issue, will try to verify

[RonnyPfannschmidt]

@nicoddemus its a compounding bug finally triggerd by the recent packaging release which removes legacy versions

pallets_sphinx_themes seems to be broken with current packaging, we need to pin theo ld one until there is a bugfix

[nicoddemus]

Do you know to which version should we pin packaging?

[RonnyPfannschmidt]

@nicoddemus anything <22 should do, its only the latest version that dropped LegacyVersion

[nicoddemus]

Thanks @RonnyPfannschmidt, pinned to < 22, however we still get the same error. Any other ideas?

Btw I'm focusing on the readthedocs build, the docs tox env is failing due to something else (seems like a pytest example in the tox docs has been removed/moved).

[nicoddemus]

Found the problem: the solution is to configure readthedocs to first install pytest into the virtualen environment, and then install doc/en/requirements.txt. The other way around would cause pytest's own dependency on packaging to overwrite the pinned packaging in doc/en/requirements.txt.