2.8.1 release #1084
2.8.1 release #1084
Conversation
importlib.invalidate_caches() - bump version to 2.8.1 - regen docs - amend changelog, authors
I could not get the pullrequest picture to be included correctly in both latex and html sphinx builders due to the "include" directive from doc/en/contributing.rst
|
release files are at https://devpi.net/hpk/dev/pytest/2.8.1 |
|
|
||
| def _possibly_invalidate_import_caches(self): | ||
| # invalidate caches if we can (py33 and above) | ||
| try: |
There was a problem hiding this comment.
cant we use from importlib import invalidate_caches to avoid the feature check in the else branch?
There was a problem hiding this comment.
probably -- but it's minor -- wouldn't want to repack/test everything for that.
There was a problem hiding this comment.
Or just do importlib.invalidate_caches() here and do except (ImportError, AttributeError): pass
There was a problem hiding this comment.
@The-Compiler nope ^^
edit
to clarify, i think the invalidate_caches call should not be protected by any kind of except clause
There was a problem hiding this comment.
ronny regards it as a matter of principle: if invalidate_caches() raises an AttributeError you would swallow it :)
|
👍 |
| @@ -73,7 +73,7 @@ If you then run it with ``--lf``:: | |||
|
|
|||
| $ py.test --lf | |||
| ======= test session starts ======== | |||
| platform linux -- Python 3.4.2, pytest-2.8.1.dev1, py-1.4.30, pluggy-0.3.1 | |||
| platform linux -- Python 3.4.3, pytest-2.8.1, py-1.4.30, pluggy-0.3.1 | |||
There was a problem hiding this comment.
No need to update this, just thought I would mention: next time we generate the examples I think (and Ronny agrees) that we should use Python 3.5 as a rule of thumb.
|
LGTM! 👍 Shame #1058 didn't make it though. |
|
we can update the docs on pytest.org after #1058 made it :) |
|
OK! 😄 |
No description provided.