WIP: Rework fixture dependency graph calculation #11533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the central part of the first point proposed in #11532.
It adds the mechanisms to shift from resolving fixtures strictly by name to building a proper fixture dependency graph.
All new objects and methods keep the interface of the objects/methods they are intended to eventually replace for now.
As mentioned in the discusion thread I wish to get some feedback if this is a direction worth pursuing further and if it is how to implement proper error reporting during collection for cyclic dependencies errors and mis-scoped dependencies errors
NOTE: The new mechanism are not used yet. ReplacingFuncFixtureInfoandFixtureManager.getfixtureinfobyFuncFictureInfo2andFixtureManager.gefixtureinfo2should mostly work but I have not tested it yet.References:
David J. Pearce and Paul H. J. Kelly. 2007. A dynamic topological sort algorithm for directed acyclic graphs. ACM J. Exp. Algorithmics 11 (2006), 1.7–es. https://doi.org/10.1145/1187436.1210590