Make deprecated_call() use monkey-patching again #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,18 +29,39 @@ def pytest_namespace(): | |||
|
|
|||
|
|
|||
| def deprecated_call(func, *args, **kwargs): | |||
| """Assert that ``func(*args, **kwargs)`` triggers a DeprecationWarning. | |||
| """ assert that calling ``func(*args, **kwargs)`` triggers a | |||
| DeprecationWarning. | |||
There was a problem hiding this comment.
should say "DeprecationWarning or PendingDeprecationWarning".
nicoddemus
force-pushed
the
deprecated-call-1190
branch
from
74c2117 to
d03e73d
Compare
|
Looks good to me. |
similar to what we had in 2.7, with a few enhancements Fix pytest-dev#1190
nicoddemus
force-pushed
the
deprecated-call-1190
branch
from
d03e73d to
603d81e
Compare
RonnyPfannschmidt
added a commit
that referenced
this pull request
Nov 27, 2015
Make deprecated_call() use monkey-patching again , fixes #1190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecated_callnow uses monkey patching strategy to capture warningssimilar to what we had in 2.7, with a few enhancements
Fix #1190
cc @hunse