Add --log-file-mode option to the logging plugin, enabling appending to log-files#11979
Merged
nicoddemus merged 4 commits intoFeb 21, 2024
Conversation
nicoddemus
approved these changes
Feb 17, 2024
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Left two minor suggestions.
…to log-files Previously, the mode was hard-coded to be "w" which truncates the file before logging. Relevant documentation has been updated and tests have been added to validate the new functionality.
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
flying-sheep
pushed a commit
to flying-sheep/pytest
that referenced
this pull request
Apr 9, 2024
…to log-files (pytest-dev#11979) Previously, the mode was hard-coded to be "w" which truncates the file before logging. Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the mode was hard-coded to be "w" which truncates the file before logging. Relevant documentation has been updated and tests have been added to validate the new functionality.
Closes #11978