[junitxml] add timezone to testsuite timestamp #12491
Merged
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joseph-sentry <[email protected]>
psf-chronographer
bot
added
the
bot:chronographer:provided
bukzor
reviewed
Jun 20, 2024
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
Signed-off-by: joseph-sentry <[email protected]> Co-authored-by: Ronny Pfannschmidt <[email protected]>
|
There was a side effect here but it took me ~13 months to notice it because of a silent failure in our CI builds. My team uses Projektor to collect and analyze JUnit XML test results. This change, released in pytest 8.3, breaks Projektor's parsing of junit XML because it doesn't expect a TZ. See craigatk/projektor#1923 for more detail. Would you accept one of these:
I'm poking at folks on the Projektor team to handle it on their end, too, in that ticket and internally (a few people at my company are contributors). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7662