Skip to content

Only override list styling in sidebar #12575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Only override list styling in sidebar #12575

wants to merge 1 commit into from

Conversation

pradyunsg
Copy link
Contributor

Closes #12573

@webknjaz webknjaz added backport 8.2.x skip news used on prs to opt out of the changelog requirement labels Jul 5, 2024
@nicoddemus
Copy link
Member

Thanks @pradyunsg!

Any reason why this still a Draft?

@ferdnyc
Copy link

ferdnyc commented Jul 6, 2024

If I'm understanding @pradyunsg correctly (see also #12576), the style.html file shouldn't be there at all, and its entire contents should be moved to a .css file that's referenced in html_css_files in the conf.py configuration. (That's what the Sphinx docs say, anyway, and Furo's documentation defers to them on this point.)

I'll put together a PR with that change, including the list-styling fixes here.

@ferdnyc ferdnyc mentioned this pull request Jul 6, 2024
Closed
@pradyunsg
Copy link
Contributor Author

Since #12581 was filed, I'll go ahead and close this out.

Any reason why this still a Draft?

Because I only did this on the browser and didn't test this out locally/online. Sorry about the lack of context being shared around that. 😅

@pradyunsg pradyunsg closed this Jul 7, 2024
@pradyunsg pradyunsg deleted the patch-1 branch July 7, 2024 10:58
@nicoddemus
Copy link
Member

Because I only did this on the browser and didn't test this out locally/online. Sorry about the lack of context being shared around that. 😅

No worries, thanks for the PR and all the other work you have been putting here, we greatly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@nicoddemus nicoddemus Awaiting requested review from nicoddemus

@RonnyPfannschmidt RonnyPfannschmidt Awaiting requested review from RonnyPfannschmidt

@The-Compiler The-Compiler Awaiting requested review from The-Compiler

@bluetech bluetech Awaiting requested review from bluetech

Assignees
No one assigned
Labels
skip news used on prs to opt out of the changelog requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR #12326 made the bullet lists in the change log invisible
4 participants
@pradyunsg @nicoddemus @ferdnyc @webknjaz