[pre-commit.ci] pre-commit autoupdate #12910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
webknjaz
reviewed
Oct 21, 2024
| @@ -550,7 +550,7 @@ def snap(self) -> bytes: | |||
| res = self.tmpfile.buffer.read() | |||
| self.tmpfile.seek(0) | |||
| self.tmpfile.truncate() | |||
| return res | |||
| return res # type: ignore[return-value] | |||
There was a problem hiding this comment.
It seems it's a false positive, the return from read() is in fact bytes and not a buffer ?
There was a problem hiding this comment.
Looks like it can be a ReadableBuffer and not bytes: https://github.com/python/typeshed/blob/ca65e08/stdlib/_io.pyi#L126C43-L126C57
There was a problem hiding this comment.
Should we fix something then (cast to str) ?
There was a problem hiding this comment.
The pre-commit bot removed our changes, I force pushed them back :)
Pierre-Sassoulas
force-pushed
the
pre-commit-ci-update-config
branch
from
4b5654d to
3fa2fa4
Compare
|
There's some deprecation warning emitted by pylint: Created pylint-dev/pylint#10043 because it seems we know what we do here. Will handle in other merge request. |
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
193469b to
fc3b6d9
Compare
Pierre-Sassoulas
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
24a6a8b to
05b72ee
Compare
This was referenced Oct 29, 2024
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
05b72ee to
b22f8af
Compare
Pierre-Sassoulas
force-pushed
the
pre-commit-ci-update-config
branch
from
35dce4d to
7fcae16
Compare
nicoddemus
approved these changes
Nov 8, 2024
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.9 → v0.7.2](astral-sh/ruff-pre-commit@v0.6.9...v0.7.2) - [github.com/adamchainz/blacken-docs: 1.19.0 → 1.19.1](adamchainz/blacken-docs@1.19.0...1.19.1) - [github.com/pre-commit/mirrors-mypy: v1.11.2 → v1.13.0](pre-commit/mirrors-mypy@v1.11.2...v1.13.0) - [github.com/tox-dev/pyproject-fmt: 2.3.1 → v2.5.0](tox-dev/pyproject-fmt@2.3.1...v2.5.0) - [github.com/asottile/pyupgrade: v3.18.0 → v3.19.0](asottile/pyupgrade@v3.18.0...v3.19.0) [mypy] Remove useless noqa, add noqa for new false positives Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Pierre-Sassoulas
force-pushed
the
pre-commit-ci-update-config
branch
from
cf6c0da to
607b9f7
Compare
|
Thanks for the review @nicoddemus, I'm going to work on #12875 for pytest 8.4 next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: