-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Upgrade ruff to 0.8.1 and fix existing issues #13009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5084e1b
to
6313502
Compare
nicoddemus
approved these changes
Nov 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @Pierre-Sassoulas for tackling this!
testing/example_scripts/dataclasses/test_compare_dataclasses_with_custom_eq.py
Outdated
Show resolved
Hide resolved
b35193a
to
17c5bbb
Compare
Thank you for the review and tips @nicoddemus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
pull requests that update a dependency file
skip news
used on prs to opt out of the changelog requirement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12875, and #12995. Lot of manual work and partial add + bissection of issues on this one. Review should be done commit by commit because there's also automated changes.