Skip to content

Import numpy conditionally in pytest.approx #13563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Import numpy conditionally in pytest.approx #13563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ Leonardus Chen
Lev Maximov
Levon Saldamli
Lewis Cowles
Liam DeVoe
Llandy Riveron Del Risco
Loic Esteve
lovetheguitar
Expand Down
1 change: 1 addition & 0 deletions changelog/13563.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:func:`pytest.approx` now only imports ``numpy`` if NumPy is already in ``sys.modules``. This fixes unconditional import behavior introduced in `8.4.0`.
7 changes: 2 additions & 5 deletions src/_pytest/python_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,12 +426,9 @@ def is_bool(val: Any) -> bool:
# Check if `val` is a native bool or numpy bool.
if isinstance(val, bool):
return True
try:
import numpy as np

if np := sys.modules.get("numpy"):
return isinstance(val, np.bool_)
except ImportError:
return False
return False

asarray = _as_numpy_array(actual)
if asarray is not None:
Expand Down