Skip to content

Remove unintentionally-unconditional skips #13842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove unintentionally-unconditional skips #13842

wants to merge 5 commits into from
+9 −13

Conversation

@Liam-DeVoe
Copy link
Contributor

@Liam-DeVoe Liam-DeVoe commented Oct 23, 2025 •
edited
Loading

pytest.mark.skip("string condition") always skips. I assume these were meant to be pytest.mark.skipif.

Do test-only fixes need a changelog entry? (Yes, at least according to CI)

@Liam-DeVoe
Copy link
Contributor Author

I was initially going to use the trivial changelog type, but apparently that was removed in #12501. I've updated CONTRIBUTING.rst to match

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Oct 23, 2025
bluetech
bluetech reviewed Oct 24, 2025
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@bluetech bluetech added the skip news used on prs to opt out of the changelog requirement label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluetech bluetech bluetech left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bot:chronographer:provided (automation) changelog entry is part of PR skip news used on prs to opt out of the changelog requirement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Liam-DeVoe @bluetech