add: nodes.norm_sep helper for nodeid path separator normalization #14120
+51
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidates scattered inline implementations into a single consistent helper. Co-authored-by: Cursor AI <[email protected]> Co-authored-by: Anthropic Claude Opus 4 <[email protected]>
RonnyPfannschmidt
added
the
skip news
There was a problem hiding this comment.
Pull request overview
This PR introduces a helper function nodes.norm_sep to normalize path separators to forward slashes, consolidating previously scattered inline implementations. This refactoring improves code maintainability and prepares the codebase for upcoming conftest fixture scoping fixes.
Changes:
- Added
nodes.norm_sep()helper function with comprehensive test coverage - Replaced inline path separator normalization in terminal.py, nodes.py, and fixtures.py
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testing/test_nodes.py | Adds comprehensive test suite for the new norm_sep helper, covering various edge cases including forward slashes, backslashes, mixed separators, PathLike objects, empty strings, and Windows absolute paths |
| src/_pytest/nodes.py | Introduces the norm_sep helper function and replaces two inline implementations with calls to this helper |
| src/_pytest/terminal.py | Replaces inline path separator normalization with nodes.norm_sep call |
| src/_pytest/fixtures.py | Replaces inline path separator normalization with nodes.norm_sep call, with improved conditional logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates scattered inline implementations into a single consistent helper.
This is a preparatory refactor for fixing conftest fixture scoping issues.