Conversation
Co-authored-by: Codex <noreply@openai.com>
psf-chronographer
Bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
approved these changes
Sep 17, 2026
| data = json.dumps(value, ensure_ascii=False, indent=2) | ||
| try: | ||
| f = path.open("w", encoding="UTF-8") | ||
| with path.open("w", encoding="UTF-8") as f: |
Member
There was a problem hiding this comment.
Nitpick we now can use path.write_text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15043.
cache.set()already warns when opening a cache file fails, but anOSErrorfrom writing or closing it currently escapes. Move the existing write into the same error handler so these failures also producePytestCacheWarning.The regression test covers open, write, and close failures. The write and close cases fail before the fix; all three pass afterward. A separate reproduction using a real file-size limit also fails on pytest 9.1.1 and unmodified main, then produces warnings with this fix.
Checks on macOS:
tox -e py313 -- -q: 4,607 passed, 51 skipped, 15 xfailed, 5 xpassed.tox -e linting: passed.JSON serialization and warning filters keep their existing behavior.
Co-developed by Poorva Barve and Codex.