issue1625, rename getfuncargvalue to getfixturevalue

[tomviner]

Fix for #1625

getfuncargvalue will be deprecated but will still be supported for the moment.

[coveralls]

Coverage increased (+0.0009%) to 92.206% when pulling 0c74f4b on tomviner:issue1625/rename-getfuncargvalue into 5d8d1db on pytest-dev:master.

[coveralls]

Coverage increased (+0.0009%) to 92.206% when pulling 0c74f4b on tomviner:issue1625/rename-getfuncargvalue into 5d8d1db on pytest-dev:master.

[The-Compiler]

Should probably also use double-backticks with the second getfuncargvalue as well?

[The-Compiler]

Might make sense to add a test for the old name as well - and a note in the doc somewhere, as well as a changelog entry?

[blueyed]

We had some discussion about skipping this renaming, if it is supposed to be deprecated later on altogether anyway?! (because fixture factories would be the recommended way)
Because by making it more visible and mentioning it in changelog etc this rather encourages to use it.

[The-Compiler]

I think @hpk42 also mentioned it's kind of impossible to deprecate/remove it since there are valid usecases without alternatives, and I agree. Some examples:

• pytest itself uses it so you can use getfixture() in doctests
• pytest-bdd heavily uses it, and I'm quite sure it's legitimate use as it dynamically generates/uses fixtures (cc @olegpidsadnyi)
• This snippet uses it to parametrize something with two different fixtures.
• A lot of users use it

[coveralls]

Coverage increased (+0.004%) to 92.234% when pulling d3a4b2a on tomviner:issue1625/rename-getfuncargvalue into 406355f on pytest-dev:master.

[coveralls]

Coverage increased (+0.004%) to 92.234% when pulling 2e9b714 on tomviner:issue1625/rename-getfuncargvalue into 406355f on pytest-dev:master.

[tomviner]

For some reason the code above passes, but this fails:

def test_getfuncargvalue_is_deprecated_with(request):
    with pytest.deprecated_call():
        request.getfuncargvalue('tmpdir')

[tomviner]

Fixes added:

• Add DeprecationWarning for usage of getfixturevalue
• DeprecationWarning is sent
• Parametrize test_getfixturevalue by getfixturevalue and getfuncargvalue, to ensure old version still works.

[coveralls]

Coverage increased (+0.004%) to 92.234% when pulling 16838af on tomviner:issue1625/rename-getfuncargvalue into 61ede09 on pytest-dev:master.

[nicoddemus]

@tomviner this one is in a conflicted state as well. 😁

[nicoddemus]

Why were these tests removed?

[coveralls]

Coverage decreased (-0.1%) to 92.139% when pulling 3719e0c on tomviner:issue1625/rename-getfuncargvalue into 144dc12 on pytest-dev:master.

[tomviner]

@nicoddemus rebased

[nicoddemus]

Hmmm lots of breakage now 😬, would you take a look please?

[tomviner]

@nicoddemus this PR was still using the old method: getfuncargvalue, and since that makes it one level deeper in the call stack, the frame traversal broke.

[coveralls]

Coverage increased (+0.004%) to 92.242% when pulling 1f059c0 on tomviner:issue1625/rename-getfuncargvalue into 24179dc on pytest-dev:master.

[coveralls]

Coverage increased (+0.004%) to 92.242% when pulling 1f059c0 on tomviner:issue1625/rename-getfuncargvalue into 24179dc on pytest-dev:master.