Testcase for overriding autouse fixture with a parametrized fixture. #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -336,6 +336,38 @@ def test_spam(spam): | |||
| result = testdir.runpytest(testfile) | |||
| result.stdout.fnmatch_lines(["*3 passed*"]) | |||
|
|
|||
| def test_override_autouse_fixture_with_parametrized_fixture_conftest_conftest(self, testdir): | |||
There was a problem hiding this comment.
Did you mean to have conftest_conftest here?
There was a problem hiding this comment.
Yes, it was deliberate. I've just followed the convention in the file from other tests.
Test case for overriding autouse fixture with a parametrized fixture. The test covers the problem explained in the issue 1601 Adding Diego Russo to AUTHORS
|
Looks good to me 👍 |
|
Thanks @diegorusso, appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to replicate the problem with the current master and the latest version (2.9.2). The test case was not present though so I created one.
pytest will raise a ValueError "Duplicate '<fixture_name>'" when overriding an autouse fixture w/ a parametrized fixture in a subdirectory's conftest.py
The related issue is #1601
Cheers