-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Improved message when not using parametrized variable #1757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved message when not using parametrized variable #1757
Conversation
Waiting for CI, but code LGTM 👍 |
@@ -146,7 +146,8 @@ time or change existing behaviors in order to make them less surprising/more use | |||
Thanks to `@anntzer`_ for the PR. | |||
|
|||
|
|||
* | |||
* Better message in case of not using parametrized variable (see `#1539`_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the message looks good, I just think it should go under the Changes
section instead of New Features
.
Thanks! Aside from my minor comments, looks good! 👍 |
Cool, happy to merge once @tramwaj29 addressed the comments. |
(@hackebrot if you could do it great, I will have to go out to lunch in a few minutes 😁) |
No worries, I won't be until tomorrow, I think. There's no rush really 😄 We'll get it in before we release 3.0 for sure. |
@hackebrot I'm not sure why the CI fails, tests on my local machine passed, I tried to merge changes from features branch into mine but there were none. |
@tramwaj29 there seems to be a conflict in |
@hackebrot yeah sorry forgot about that 🐶 |
Thank you @tramwaj29! 😃 |
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
master
; for new features, targetfeatures
;AUTHORS
;CHANGELOG.rst
CHANGELOG
, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.