Skip to content

Add note about not monkey-patching builtins #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2016
Merged

Add note about not monkey-patching builtins #1986

merged 2 commits into from
Oct 5, 2016

Conversation

nicoddemus
Copy link
Member

Related to #1985

@nicoddemus nicoddemus mentioned this pull request Oct 5, 2016
Closed
4 tasks
RonnyPfannschmidt
RonnyPfannschmidt approved these changes Oct 5, 2016
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, please mention -s as well

doc/en/monkeypatch.rst

Be advised that it is not recommended to patch builtin functions such as ``open``,
``compile``, etc., because it might break pytest's internals. If that's
unavoidable, passing ``--tb=native`` and/or ``--assert=plain`` might help althought
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also -s ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@nicoddemus
Copy link
Member Author

(once this passes let's squash and merge please)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.949% when pulling 7e00362 on nicoddemus:monkeypatch-builtins-docs into d47ae79 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.949% when pulling 8fd5e09 on nicoddemus:monkeypatch-builtins-docs into d47ae79 on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

only trial fails

@RonnyPfannschmidt RonnyPfannschmidt merged commit 50b960c into pytest-dev:master Oct 5, 2016
@nicoddemus
Copy link
Member Author

Thanks!

@nicoddemus nicoddemus deleted the monkeypatch-builtins-docs branch October 5, 2016 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @coveralls @RonnyPfannschmidt