Refactor recwarn to use warnings.catch_warnings instead of custom code #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we dropped 2.5, we can now use warnings.catch_warnings to do the "catch warnings" magic for us, simplifying the code a bit.
nicoddemus
commented
Mar 13, 2017
| def test_record(self): | ||
| with pytest.warns(UserWarning) as record: | ||
| warnings.warn("user", UserWarning) | ||
|
|
||
| assert len(record) == 1 | ||
| assert str(record[0].message) == "user" | ||
|
|
||
| print(repr(record[0])) |
There was a problem hiding this comment.
This was testing that record was a RecordedWarning, which has been replaced by warnings own tuple.
No longer test for implementation details of recwarn since warnings.catch_warnings has changed significantly in 3.6.
nicoddemus
commented
Mar 13, 2017
| @@ -8,25 +8,19 @@ | |||
| def test_recwarn_functional(testdir): | |||
| reprec = testdir.inline_runsource(""" | |||
| import warnings | |||
| oldwarn = warnings.showwarning | |||
There was a problem hiding this comment.
This is test and test_recording below were testing an implementation detail which is no longer true in 3.6, because catch_warnings has changed significantly since 3.5.
| @@ -115,19 +114,14 @@ def warns(expected_warning, *args, **kwargs): | |||
| return func(*args[1:], **kwargs) | |||
|
|
|||
|
|
|||
| RecordedWarning = namedtuple('RecordedWarning', ( | |||
There was a problem hiding this comment.
isnt that a breach of api? is it exposed in 3.0 ?
There was a problem hiding this comment.
No, that was added by you in features branch for 3.1, so it has never seen the light of day.
RonnyPfannschmidt
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we dropped 2.5, we can now use warnings.catch_warnings to do the
"catch warnings" magic for us, simplifying the code a bit.
This is the refactoring I mentioned in #2298, which will ultimately be useful to finish #2072.