Skip to content

Consider all modules #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RonnyPfannschmidt
Copy link
Member

this pr is to make the plugin manager run consider_module on all modules registred as plugin

this is supposed to address #2391 in a more general manner
however after moving the trigger i get a lot of errors that are hard to comprehend because pytest-spagetti

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.477% when pulling 8bcf88e on RonnyPfannschmidt:consider-all-modules into daca618 on pytest-dev:features.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus that it passes here is most interesting, i get failures locally

@nicoddemus
Copy link
Member

It also passes for me locally:

  py27: commands succeeded
  py35: commands succeeded
  congratulations :)

@RonnyPfannschmidt
Copy link
Member Author

passes on tox as well

@RonnyPfannschmidt
Copy link
Member Author

after recreating my environment it seems to work

@RonnyPfannschmidt RonnyPfannschmidt changed the title [experiment] Consider all modules Consider all modules May 12, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.346% when pulling a92e397 on RonnyPfannschmidt:consider-all-modules into daca618 on pytest-dev:features.

@nicoddemus nicoddemus merged commit 456925b into pytest-dev:features May 12, 2017
@RonnyPfannschmidt RonnyPfannschmidt deleted the consider-all-modules branch June 11, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants