ignore valid setup.py during --doctest-modules

[aysonje]

Addresses #502

• Add a new news fragment into the changelog folder
  • name it $issue_id.$type for example (588.bug)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
• Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
• Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

• Add yourself to AUTHORS;

[aysonje]

Hi, I wanted to check first if I'm on the right track in fixing the issue before I work on tests and other required things for a pull request. :)

[coveralls]

Coverage decreased (-0.03%) to 92.208% when pulling 0014e8d on aysonje:ignore-setup into 46e3043 on pytest-dev:master.

[RonnyPfannschmidt]

good start on this low hanging fruit 👍 ,
since it has some backward compat implications please target the features branch

[RonnyPfannschmidt]

just use path.read() to get the content

[coveralls]

Coverage increased (+0.007%) to 92.676% when pulling eaf38c7 on aysonje:ignore-setup into c750a5b on pytest-dev:features.

[coveralls]

Coverage increased (+0.004%) to 92.672% when pulling eaf38c7 on aysonje:ignore-setup into c750a5b on pytest-dev:features.

[nicoddemus]

The new failures are happening because I improved the formatting a bit in the changelog, but they are related to #2843. This was passing just fine in eaf38c7.

[coveralls]

Coverage increased (+0.004%) to 92.672% when pulling 843872b on aysonje:ignore-setup into c750a5b on pytest-dev:features.