-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Deprecation Roadmap to backward compatibility document #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deprecation Roadmap to backward compatibility document #2931
Conversation
We should replace the wiki document to a link to this document now
Hi @nicoddemus! 👋 I'm not entirely sure about what order I prefer. If we're going to keep it at just two versions it probably doesn't make too much difference, but if we're going to extend the list, I'd like to see the upcoming release first, then any future releases, followed by a section for deprecations in past versions. |
Hi @hackebrot!
This is the order that is in the document already... would you like me to change something? It is not very clear to me from your comment if you want me to change something. |
I think I'd add section headers
Or describe the order in the section description. |
@hackebrot added Future/Past releases as you suggested. I didn't add a "upcoming" release because I think it will be tedious to maintain it for each release, seems better to just explicitly declare in which versions some things will be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for the review! 👍 |
We should replace the wiki document to a link to this document now: https://github.com/pytest-dev/pytest/wiki/Deprecation-Roadmap
Rationale: the Wiki is not really used by us so I doubt users look at it, plus deprecation always involves code so it makes sense to update the document in the same PR.