Improve getscopeitem assertion message #2983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Nov 30, 2017
blueyed
reviewed
Nov 30, 2017
_pytest/fixtures.py
Outdated
| @@ -553,7 +553,7 @@ def _getscopeitem(self, scope): | |||
| if node is None and scope == "class": | |||
| # fallback to function item itself | |||
| node = self._pyfuncitem | |||
| assert node | |||
| assert node, 'Could not obtain a node for scope "{}" for function {!r}'.format(self._pyfuncitem) | |||
There was a problem hiding this comment.
Shouldn't there be two args to format()? (scope is missing)
There was a problem hiding this comment.
Definitely, thanks for catching it! 😉
That's your morning coffee not kicking in yet. 😅
nicoddemus
force-pushed
the
improve-assert-2979
branch
from
682b94d to
70f1e3b
Compare
blueyed
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2979