Skip to content

Fix test for py37 #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Fix test for py37 #3167

merged 1 commit into from
Feb 2, 2018

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jan 30, 2018

In previous Python versions, the list of warnings when pytest.warns fails appears like:

	... list of emitted warnings is: [UserWarning('user',)].

In Python 3.7 apparently the string representation has been improved to:

	... list of emitted warnings is: [UserWarning('user')].

Fix #3011

I would recommend to leave py37 in the "allowed failures" section for now, at least until py37 releases its first beta.

In previous Python versions, the list of warnigns appears like:

	... list of emitted warnings is: [UserWarning('user',)].

In Python 3.7 apparently the string representation has been improved to:

	... list of emitted warnings is: [UserWarning('user')].

Fix pytest-dev#3011
@nicoddemus nicoddemus mentioned this pull request Jan 30, 2018
2 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.628% when pulling 90a8faa on nicoddemus:fix-py37 into f2fb841 on pytest-dev:master.

@nicoddemus nicoddemus merged commit 8c81722 into pytest-dev:master Feb 2, 2018
@nicoddemus nicoddemus deleted the fix-py37 branch February 2, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants