Skip to content

#3332 improve traceback for import error #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feuillemorte wants to merge 6 commits into from
Closed

#3332 improve traceback for import error #3345

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19aab63
#3332 Improved tracebacks for ImportErrors in conftest
feuillemorte Mar 27, 2018
9b5b9e3
#3332 Fix tests for new traceback
feuillemorte Mar 27, 2018
fdb5c25
#3332 Added changelog file
feuillemorte Mar 27, 2018
12a5f60
Merge remote-tracking branch 'upstream/features' into 3332-improve-tr…
feuillemorte Mar 27, 2018
acbf49a
#3332 Fix message
feuillemorte Mar 27, 2018
75497b1
#3332 Added traceback function
feuillemorte Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions _pytest/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __str__(self):
etype, evalue, etb = self.excinfo
formatted = traceback.format_tb(etb)
# The level of the tracebacks we want to print is hand crafted :(
return repr(evalue) + '\n' + ''.join(formatted[2:])
return ''.join(formatted[2:]) + '\nE ' + etype.__name__ + ': ' + str(evalue)
Copy link
Contributor Author

@feuillemorte feuillemorte Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this line? Is it good? Now it looks like

E    ModuleNotFoundError: No module named 'wrong_import'



def main(args=None, plugins=None):
Expand All @@ -52,9 +52,15 @@ def main(args=None, plugins=None):
config = _prepareconfig(args, plugins)
except ConftestImportFailure as e:
tw = py.io.TerminalWriter(sys.stderr)
for line in traceback.format_exception(*e.excinfo):
tw.line(line.rstrip(), red=True)
tw.line("ERROR: could not load %s\n" % (e.path,), red=True)
formatted_tb = safe_str(e)
tw.line(
"ImportError while importing conftest module '{path}'.\n"
"Hint: make sure your test modules/packages have valid Python names.\n"
"Traceback:\n"
"{traceback}".format(path=e.path, traceback=formatted_tb),
red=True
)

return 4
else:
try:
Expand Down
1 change: 1 addition & 0 deletions changelog/3332.trivial
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improved tracebacks for ImportErrors in conftest.py
6 changes: 3 additions & 3 deletions testing/acceptance_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ def test_issue486_better_reporting_on_conftest_load_failure(self, testdir):
*warning*conftest.py*
""")
result = testdir.runpytest()
result.stderr.fnmatch_lines("""
*ERROR*could not load*conftest.py*
""")
result.stderr.fnmatch_lines(["*ImportError while importing conftest module*conftest.py*",
"E *Error: No module named*qwerty*"]
)

def test_early_skip(self, testdir):
testdir.mkdir("xyz")
Expand Down