Skip to content

Add package scoped fixtures #2283 #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 59 commits into from
Closed

Add package scoped fixtures #2283 #3386

wants to merge 59 commits into from

Conversation

jonozzz
Copy link

@jonozzz jonozzz commented Apr 11, 2018

In response to #2283, adding package scoped fixtures, that follow python-nose's implementation.

package/
  __init__.py
  test_foo.py

# __init__.py
def setup_module():
  print("Setting up the package")

def teardown_module():
  print("Tearing down the package")

In this case teardown_module() will be executed when all tests in test_foo.py are done.

nicoddemus and others added 30 commits March 26, 2018 11:20
@nicoddemus
Update typo in fixture.rst
ff3d13e
@jeffreyrack
Update pytest.raises to raise a TypeError when an invalid keyword arg…
34afded 
…ument is passed.
@jeffreyrack
Change pytest.raises to use match instead of matches
a5d9fbe
@nicoddemus
Use shorter 'if kwargs' check as requested during review
bfe773b
@nicoddemus
Update changelog formatting
7656581
@RonnyPfannschmidt
Merge pull request #3349 from jeffreyrack/3348-unknown-argument
2efaf39 
3348: raise error on unknown arguments to raises
@nicoddemus
Add docs about using pytest.param in parametrized fixtures
0a3cd88
@RonnyPfannschmidt
Merge pull request #3353 from nicoddemus/fixture-param-marks-docs
f1c9efc 
Add docs about using pytest.param in parametrized fixtures
@irmen
chage collections.abc import to fix deprecation warnings on python 3.7
faded25
@nicoddemus
Move compatibility imports to compat.py and fix linting
8ca9321
@nicoddemus
Move compatibility imports to compat.py and fix linting
6a81aae
@nicoddemus
Remove stale CHANGELOG entries
e5eba84 
Those were not removed in the last release because of a bug in
towncrier; I was about to fallback to don't use the .rst extension
for entries but just noticed that this was fixed in towncrier 17.8.0
so it should no longer be a problem.
@nicoddemus
Add reference docs for pytest_sessionstart/finish and update their do…
daf1de0 
…cstrings
@nicoddemus
Switch imports based on python versions, my bad
3fc2c94
@flub
Merge pull request #3356 from nicoddemus/remove-stale-changelog-entries
77128ee 
Remove stale CHANGELOG entries
@RonnyPfannschmidt
record_property is no longer experimental
211f3c4
@nicoddemus
Merge pull request #3355 from irmen/py37deprfixes
9a62ebf 
change collections.abc import to fix deprecation warnings on python 3.7
@RonnyPfannschmidt
Merge pull request #3357 from nicoddemus/session-hooks-ref
9326759 
Add reference docs for pytest_sessionstart/finish and update their docstrings
@RonnyPfannschmidt
fix record_property test
7c0c91a
Use correct spelling for "more-itertools"
9aa2a83
@RonnyPfannschmidt
Merge pull request #3364 from sscherfke/more-itertools
ad0b433 
Use correct spelling for "more-itertools"
@RonnyPfannschmidt
fix the record_property test
2018cf1
@dchudz
no-capture in sample code demo'ing plugin
db24723
@nicoddemus
Merge pull request #3360 from RonnyPfannschmidt/xml_property_yay
ef34de9 
record_property is no longer experimental
@nicoddemus
Merge pull request #3370 from dchudz/patch-1
ab91771 
no-capture in sample code demo'ing plugin
@nicoddemus
Remove label descriptions from development guide
f17dfa4 
The descriptions have been moved directly to GitHub's new label description
slot.
@RonnyPfannschmidt
Merge pull request #3371 from nicoddemus/remove-labels-descriptions
5d4fe87 
Remove label descriptions from development guide
@Ohj8odah
Fix issue #3372
ec2d822
@Ohj8odah
Ensure object is class before calling issubclass.
0cd74dc
@Ohj8odah
Follow Ronny's advice and use type in base_type.
846d91f
@nicoddemus
Copy link
Member

Hi @jonozzz, thanks a lot for working on this!

Could you please rebase against the latest features though? Your PR has a lot of commits which are not related to your change.

Looking forward to review this! 😁

nicoddemus and others added 25 commits April 11, 2018 13:43
@nicoddemus
Update typo in fixture.rst
52a3bd2
@jeffreyrack
Update pytest.raises to raise a TypeError when an invalid keyword arg…
94eb0de 
…ument is passed.
@jeffreyrack
Change pytest.raises to use match instead of matches
df4657a
@nicoddemus
Use shorter 'if kwargs' check as requested during review
6ab0431
@nicoddemus
Update changelog formatting
942db75
@nicoddemus
Add docs about using pytest.param in parametrized fixtures
0d36860
@nicoddemus
Remove stale CHANGELOG entries
60444d2 
Those were not removed in the last release because of a bug in
towncrier; I was about to fallback to don't use the .rst extension
for entries but just noticed that this was fixed in towncrier 17.8.0
so it should no longer be a problem.
@irmen
chage collections.abc import to fix deprecation warnings on python 3.7
2d2e187
@nicoddemus
Move compatibility imports to compat.py and fix linting
c52a092
@nicoddemus
Move compatibility imports to compat.py and fix linting
1631c7f
@nicoddemus
Switch imports based on python versions, my bad
67443b5
@nicoddemus
Add reference docs for pytest_sessionstart/finish and update their do…
8163f1a 
…cstrings
Use correct spelling for "more-itertools"
478a6f0
@RonnyPfannschmidt
record_property is no longer experimental
9cf7819
@RonnyPfannschmidt
fix record_property test
b40eded
@RonnyPfannschmidt
fix the record_property test
e6d17aa
@dchudz
no-capture in sample code demo'ing plugin
6b2bda1
@nicoddemus
Remove label descriptions from development guide
dbea2b3 
The descriptions have been moved directly to GitHub's new label description
slot.
@Ohj8odah
Fix issue #3372
cd0c6e0
@Ohj8odah
Ensure object is class before calling issubclass.
3234cbe
@Ohj8odah
Follow Ronny's advice and use type in base_type.
d28030f
@Ohj8odah
linting: unfortunate dedent be gone.
5f27fa4
Add package scoped fixtures #2283
adfaca6
Updated AUTHORS and added item to changelog.
633578a
Merge branch 'master' of github.com:jonozzz/pytest
0017e6a
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.769% when pulling 0017e6a on jonozzz:master into 372bcdb on pytest-dev:features.

@jonozzz jonozzz closed this Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jonozzz @nicoddemus @coveralls @jeffreyrack @RonnyPfannschmidt @irmen @flub @dchudz @Ohj8odah