-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix 3605 #3606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3605 #3606
Conversation
changelog/3605.bugfix.rst
Outdated
@@ -0,0 +1 @@ | |||
unpack marks from parameterization to prevent the markdecorator missmatch bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we phrase this in a way that end users (that don't know the internals) can understand? 🤔
return normalize_mark_list(mark_list) | ||
|
||
|
||
def normalize_mark_list(mark_list): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a docstring here explaining why this is needed
btw, I don't think GitHub looks at the title of the PR to automatically close issues:
https://help.github.com/articles/closing-issues-using-keywords/ 😉 edit: I just noticed that your last commit does include "fix " so this is of course fine. 😁 |
1445a87
to
643e5a9
Compare
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.master
branch for bug fixes, documentation updates and trivial changes.features
branch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORS
in alphabetical order;