Use bytes directly instead of binary_type
#3868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bytes` is an alias for `str` in python2.6+
asottile
commented
Aug 24, 2018
| else: | ||
| t = six.binary_type | ||
| return repr.replace(t("\n"), t("\\n")) | ||
| return r.replace(b"\n", b"\\n") |
Member
Author
There was a problem hiding this comment.
Note that bytes("string literal") in python3+ is a TypeError so I fixed these as well.
As far as I can tell however this situation is impossible as __repr__ raises for non str types in python3.x
| else: | ||
| t = six.binary_type | ||
| return explanation.replace(t("%"), t("%%")) | ||
| return explanation.replace(b"%", b"%%") |
Member
Author
There was a problem hiding this comment.
this one however seems maybe possible? I'm not sure how this code gets called 🤷♂️
nicoddemus
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytesis an alias forstrin python2.6+