Skip to content

Update usefixtures documentation #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2018
Merged

Update usefixtures documentation #4121

merged 1 commit into from
Oct 12, 2018

Conversation

cacoze
Copy link
Contributor

@cacoze cacoze commented Oct 12, 2018 •
edited by nicoddemus
Loading

Fixes #3713

@cacoze
Update usefixtures documentation
dbaa946 
Clarifying that it can't be used with fixture functions
@cacoze cacoze changed the title Update usefixtures documentation to clarify that it can't be used wit… Update usefixtures documentation Oct 12, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.801% when pulling dbaa946 on labcodes:3713 into 0f5263c on pytest-dev:master.

nicoddemus
nicoddemus approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacoze!

@crazymerlyn crazymerlyn merged commit d46b6b2 into pytest-dev:master Oct 12, 2018
@nicoddemus
Copy link
Member

Hey @crazymerlyn, thanks for merging this, just a friendly heads-up: in general we should wait for the CI to finish, even for documentation changes. Our docs tox environment checks for documentation errors, so it may fail the build if there are syntax errors in the .rst (for example).

Of course this change is trivial, but it is good to avoid exceptions to the protocol. 😁

@crazymerlyn
Copy link
Member

@nicoddemus Thanks for the heads up. Will keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@crazymerlyn crazymerlyn crazymerlyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cacoze @coveralls @nicoddemus @crazymerlyn