_getconftestmodules: avoid isfile()/dirpath() #4224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4224 +/- ##
==========================================
+ Coverage 93.38% 95.86% +2.47%
==========================================
Files 109 109
Lines 24585 24590 +5
Branches 2389 2392 +3
==========================================
+ Hits 22959 23573 +614
+ Misses 1308 721 -587
+ Partials 318 296 -22
Continue to review full report at Codecov.
|
|
The 2nd commit also uses lru_cache missing in py27. |
blueyed
force-pushed
the
_getconftestmodules
branch
from
1acb18b to
b46d42d
Compare
|
I am taking out the 2nd commit (1acb18b). |
blueyed
commented
Oct 24, 2018
| @@ -399,7 +399,7 @@ def _getconftestmodules(self, path): | |||
| mod = self._importconftest(conftestpath) | |||
| clist.append(mod) | |||
|
|
|||
| self._path2confmods[directory] = clist | |||
| self._path2confmods[path] = clist | |||
There was a problem hiding this comment.
Note that with 1acb18b I've noticed that some other code might expect a dirpath in self._path2confmods - haven't checked if I broke this with the previous optimization already though.
blueyed
force-pushed
the
_getconftestmodules
branch
from
b46d42d to
63691f5
Compare
nicoddemus
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2206 (comment)
I cannot see a real difference myself with clock time (1.2s vs 1.15s with some project and
-k doesnotmatch), but I think it makes sense anyway, and might help with the above comment.For pytest itself:
new: 1 loop, best of 5: 1.73 sec per loop
old: 1 loop, best of 5: 1.61 sec per loop
However, pytest itself displays "2287 deselected in 1.06 seconds" vs "2287 deselected in 1.22 seconds".