Skip to content

tests: fix equal_with_bash to handle appearing .coverage files #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 9, 2018

Fixes #4162.

@blueyed blueyed added the type: infrastructure improvement to development/releases/CI structure label Nov 9, 2018
@blueyed blueyed force-pushed the fix-equal_with_bash branch from 685e3c9 to 929e7a6 Compare November 9, 2018 04:40
@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #4356 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4356      +/-   ##
==========================================
+ Coverage   95.83%   95.85%   +0.02%     
==========================================
  Files         111      111              
  Lines       24907    24910       +3     
  Branches     2431     2431              
==========================================
+ Hits        23869    23877       +8     
+ Misses        738      736       -2     
+ Partials      300      297       -3
Flag Coverage Δ
#docs 28.88% <0%> (-0.01%) ⬇️
#doctesting 28.88% <0%> (-0.01%) ⬇️
#linting 28.88% <0%> (-0.01%) ⬇️
#linux 95.64% <100%> (+0.02%) ⬆️
#nobyte 91.85% <100%> (ø) ⬆️
#numpy 93.01% <0%> (+0.01%) ⬆️
#pexpect 41.62% <0%> (+0.01%) ⬆️
#py27 94.03% <100%> (+0.02%) ⬆️
#py34 92.16% <100%> (+0.06%) ⬆️
#py35 92.16% <100%> (+0.06%) ⬆️
#py36 93.91% <100%> (+0.02%) ⬆️
#py37 92.21% <100%> (+0.06%) ⬆️
#trial 93.01% <0%> (+0.01%) ⬆️
#windows 93.96% <0%> (-0.01%) ⬇️
#xdist 93.73% <100%> (ø) ⬆️
Impacted Files Coverage Δ
testing/test_argcomplete.py 68.11% <100%> (+1.44%) ⬆️
src/_pytest/terminal.py 93.02% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14ca19...b51c1c3. Read the comment docs.

@blueyed blueyed requested a review from asottile November 9, 2018 04:41
@blueyed blueyed force-pushed the fix-equal_with_bash branch from 929e7a6 to b51c1c3 Compare November 10, 2018 02:24
@blueyed blueyed requested a review from asottile November 10, 2018 23:41
@blueyed blueyed changed the title tests: ignore .coverage files with equal_with_bash tests: fix equal_with_bash to handle appearing .coverage files Nov 10, 2018
@blueyed blueyed merged commit 7ab3d81 into pytest-dev:master Nov 10, 2018
@blueyed blueyed deleted the fix-equal_with_bash branch November 10, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants